Fix/Serialized Property Regex removal #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyTheunissen
approved these changes
Aug 24, 2024
| private static void ParseFieldStructure(string input, out string fieldName, out int index) | ||
| { | ||
| int startIndex = input.IndexOf('['); | ||
| int endIndex = input.IndexOf(']'); |
There was a problem hiding this comment.
Suggested change
| int endIndex = input.IndexOf(']'); | |
| int endIndexSearchStart = Mathf.Min(startIndex + 1, input.Length - 1); | |
| int endIndexSearchCount = Mathf.Min(9, input.Length - startIndex - 1); | |
| int endIndex = input.IndexOf(']', endIndexSearchStart, endIndexSearchCount ); |
The end index is supposed to always be shortly after the start index, right?
So it would be good to start looking right after the start index. You could also limit it to a few characters (say, 8).
Then we have to make sure it doesn't exceed the length of the string because that would throw an ArgumentOutOfRangeException apparently
This would die a horrible death if startIndex is -1 but I think it's supposed to always be there, right?
Maybe using a search count is unnecessary hassle. At the very least you should be able to use a start index though 😄
RoyTheunissen
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.